On Mon, 28 Apr 2025 16:19:09 GMT, Frederic Thevenet <ftheve...@openjdk.org> wrote:
> **Please note that this is not a formal review, as I am not an OpenJDK > reviewer.** > > `createWindowsDevkit.sh` will fail to run when MSYS2 is started under any > other environment[1] other than "MSYS" (i.e. `MINGW64`, `UCRT64`, `CLANG64`, > etc...), because for all other env, `uname -s` will return > `MINGW64_NT-10.0-26100` instead of `MSYS_NT-10.0-26100` which throws off the > cygwin/msys2/wsl detection. > > Is this deliberate, so as to ensure only the MSYS environment is supported > for this feature, or an oversight? > > Cheers! > > [1] https://www.msys2.org/docs/environments/ Thanks for testing it. I checked other environments and think it's more reliable to check output of `uname -o` for msys. It always output 'Msys' in my testing. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24916#issuecomment-2837295634
