On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> According to > https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should > not build gtest with `/EHsc`. > > I can honestly say I don't fully understand the consequences of this change, > but at least it passes building and testing on Oracle CI. And it does seem to > make sense that we build the gtest version of libjvm as close as possible to > the real version. For libgtest I just thought it was prudent to keep the > flags in sync with how we build libjvm. This might not be the correct > decision. > > I have not tested how or if this affects the ability for gtest to handle bugs > or crashes in the JVM, nor do I really have any idea about any such > consequences. This PR is opened more to start a discussion than with the > intention of just integrating this. make/hotspot/lib/CompileGtest.gmk line 112: > 110: DISABLED_WARNINGS_clang_test_g1ServiceThread.cpp := > delete-abstract-non-virtual-dtor, \ > 111: DISABLED_WARNINGS_clang_test_logDecorations.cpp := > missing-field-initializers, \ > 112: DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) 4530, \ How widespread are these warnings? I expect such a warning from jfr/test_networkUtilization.cpp, but not anywhere else. Could the disable of this warning be narrowed accordingly? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26721#discussion_r2276648787
