On Thu, 14 Aug 2025 09:27:24 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> If I recall correctly the original approach was even simpler: I counted the 
> number of #includes in the C++ source files, not in the dependency files of a 
> particular build. Crude but effective, and left out discussions about 
> differences between platforms and feature configurations. And then I had to 
> do some adjustments for Windows where my approach of excluding inline files 
> did not hold and caused a regression.

That was also the initial approach in this PR, I got the suggestion from the 
first comments I got here.

> But then again, this is basically an optimization problem (even if it is not 
> about running code in the JVM, but about optimizing build speed) so there is 
> no way around the mantra of measure, measure and measure again.

Yeah I see, I'll give it another shot next week.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26681#issuecomment-3191518492

Reply via email to