On Mon, 25 Aug 2025 12:54:35 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 25 >> additional commits since the last revision: >> >> - revert >> - Merge branch 'master' into refresh-precompiled-hotspot >> - comment >> - nn >> - conditional >> - time-trace >> - conditional includes >> - variants >> - magic number: 400 >> - inline >> - ... and 15 more: https://git.openjdk.org/jdk/compare/d3649fee...aea7c793 > > src/hotspot/share/precompiled/precompiled.hpp line 33: > >> 31: >> 32: #include "classfile/javaClasses.inline.hpp" >> 33: #if INCLUDE_SHENANDOAHGC > > So the common style is to move conditional includes at the end of the include > block. I think the same rule applies here. Right, ba6f372d87765417f1bf05cd2b1a7e058c18350d ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2298044735
