On Mon, 25 Aug 2025 21:24:50 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>>> Apart from that, I still share Kim's worry that the platform with the most >>> potential impact is Windows, and we have no numbers at all there. >> >> I did run a quick comparison on Windows with an early version of this patch >> and it was basically a wash compared to before (slightly slower but could >> just be variance). I just reran with the latest patch and saw a slight >> improvement. Could still just be variance, but here are the numbers for >> running `make hotspot` immediately after `make clean-hotspot` to really >> isolate just the hotspot build. I warmed up caches by first building hotspot >> from scratch before cleaning. >> >> Baseline (@57434c73eac9bd6557b09d4a057e3a2a18f382b4): 4m38 >> This branch (@2f97d57b55fc838b30cf0d730c6119bf97749c6b): 4m30, 4m33 >> >> I only did one baseline run and then 2 on the branch. It's enough to show no >> regression. > >> I added them back in >> [4a2ff56](https://github.com/openjdk/jdk/commit/4a2ff5649ba9dc6a024aeb7577d630a3fefcbe4f), >> there's only two of them since the others are now always included. @erikj79 >> any chance you could try once again and see if >> [4a2ff56](https://github.com/openjdk/jdk/commit/4a2ff5649ba9dc6a024aeb7577d630a3fefcbe4f) >> has any effect on build time? > > I ran two more times: > > This branch (@4a2ff5649ba9dc6a024aeb7577d630a3fefcbe4f): 4m37, 4m29 > > So basically unchanged. Thanks @erikj79 for testing! And thanks @fandreuz for preparing the code for testing. I agree, there is no reason to keep the `inline` files if they do not improve performance. I think this is finally ready to be checked in. Thank you so much for your hard work and dedication. I have just one last request: How did you generate the last version? The script that you used to read the `.d` files has disappeared somewhere along the way, with no replacement. If you could do this with just some simple command line with pipes etc, that command line should be added as a comment to the PCH file. If you used a script, I think that script should be checked in (in `make/scripts`; even if it is a Java file). ------------- PR Comment: https://git.openjdk.org/jdk/pull/26681#issuecomment-3224320806
