On Tue, 12 May 2026 07:11:41 GMT, Stefan Karlsson <[email protected]> wrote:

>> Coleen Phillimore has updated the pull request with a new target base due to 
>> a merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains six additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'master' into coh-default
>>  - Fix CDSPluginTest and remove comment.
>>  - Reworked OMT/COH warning to always warn with -OMT and +COH.  Fixed build 
>> --enable-cds-archive-coh to nocoh.
>>  - Update test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java
>>    
>>    Co-authored-by: Fredrik Bredberg <[email protected]>
>>  - Add warning about incompatible COH with OMT.
>>  - Make UseCompactObjectHeaders the default and adjust CDS archives.
>
> make/Images.gmk line 145:
> 
>> 143:   # enable and also explicitly disable coh as needed.
>> 144:   ifeq ($(call isTargetCpuBits, 64), true)
>> 145:     $1_$2_NOCOH_OPTION := -XX:+UnlockExperimentalVMOptions \
> 
> Comments in this section still refers to _coh and not _nocoh.

Fixed- thank you for noticing this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3236565970

Reply via email to