On Wed, 13 May 2026 18:31:45 GMT, Coleen Phillimore <[email protected]> wrote:
>> This change makes UseCompactObjectHeaders default and switches the sense of >> the CDS archive naming. Now classes.jsa is with UseCompressedOops + >> UseCompactObjectHeaders (both default). Then theres: >> classes_nocoops.jsa >> classes_nocoh.jsa >> classes_nocoops_nocoh.jsa >> >> Hopefully someday we won't need the nocoh versions. >> >> Tested with tier1-8. With only one issue also fixed in this change, and no >> other new issues found. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix comments for nocoh in Images.gmk. A couple of more questions. test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java line 79: > 77: */ > 78: > 79: /* @test VMOptionWarningCompactObjectHeaders This has the same string as the run block above. Is that a bug? Also, other tests use id=<various descriptive identifiers>. Is the above a short-hand for that, or is this missing the id= part? test/jdk/tools/jlink/plugins/CDSPluginTest.java line 82: > 80: boolean NOCOMPACT_HEADERS = Platform.is64bit() && > 81: > wb.getBooleanVMFlag("UseCompactObjectHeaders") && > 82: > !wb.isDefaultVMFlag("UseCompactObjectHeaders"); Is this correct? It seems to set NOCOMPACT_HEADERS to true if someone has explicitly used -XX:+UseCompactObjectHeaders ------------- PR Review: https://git.openjdk.org/jdk/pull/30322#pullrequestreview-4284476326 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3236697192 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3236679670
