On Wed, 10 Jun 2026 07:13:39 GMT, David Simms <[email protected]> wrote:
>> This pull request implements the first >> [preview](https://openjdk.org/jeps/12) of [JEP 401: Value Classes and >> Objects](https://openjdk.org/jeps/401): >> >> - [JDK-8317277](https://bugs.openjdk.org/browse/JDK-8317277): Java language >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31121 >> - [JDK-8317278](https://bugs.openjdk.org/browse/JDK-8317278): JVM >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31122 >> - [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279): Standard >> library implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31123 >> >> This pull request also includes the implementation of [Strict Field >> Initialization in the JVM (Preview)](https://openjdk.org/jeps/8350458) (yet >> to have been assigned a JEP number). That work was implemented in the same >> code base because JEP 401 depends on strict field initialization. >> >> This is the "*master pull request*" for the initial preview of [JEP >> 401](https://openjdk.org/jeps/401). Comments and review for a change this >> large will not scale well in a single pull request. This pull request serves >> as the vehicle for sign-off and integration into >> [`jdk/master`](https://github.com/openjdk/jdk). **Review comments should be >> directed to the appropriate "*sub-review pull request*" listed above.** >> >>> [!NOTE] >>> The "*sub-review pull requests*" contain the same full set of code changes >>> as this "*master pull request*" to preserve the full implementation >>> context; the language compiler, JVM, and standard library changes are >>> intertwined. The separate pull requests exist only to subdivide the review >>> and related discussion by area. >> >> Any resulting code changes should be made in >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/). >> >> `valhalla/lworld` is currently updated from `jdk/master` whenever a weekly >> [`jdk` tag](https://github.com/openjdk/jdk/tags) is created. At that time, >> code changes from `valhalla/lworld` will be propagated to this pull request >> and to all sub-review pull requests. >> >> Ultimately, review sign-off will be recorded on this "*master pull >> request*", and the "*sub-review pull requests*" will be closed without >> integration. >> >> This pull request has a large surface area and frequently conflicts with >> `jdk/master`. Refer to >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/) for the latest >> state of the project code, keeping in mind that it may lag several days >> behind `jdk/mast... > > David Simms has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 2799 commits: > > - Merge remote-tracking branch 'valhalla/lworld' into 8317277 > - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java > > Reviewed-by: liach > - 8386242: [lworld] Simplify and clarify StrictProcessor > > Reviewed-by: dsimms > - 8386140: [lworld] FieldReflector using wrong Class argument > > Reviewed-by: alanb, dsimms > - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder > > Reviewed-by: dsimms > - Merge remote-tracking branch 'valhalla/lworld' into 8317277 > - 8385170: [lworld] Serialization spec needs to allow abstract value classes > like Number > > Reviewed-by: liach > - 8385980: [lworld] Standardize pattern for preview value class generation > > Reviewed-by: liach > - 8386086: [lworld] > sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be > removed from problem list > > Reviewed-by: liach, dcubed > - Merge > > Merge jdk-28+1 > - ... and 2789 more: https://git.openjdk.org/jdk/compare/92298786...26c8f2e4 src/java.base/share/classes/java/lang/Object.java line 314: > 312: * <div class="preview-comment"> > 313: * If this object is a {@linkplain > java.util.Objects#hasIdentity value object}, > 314: * it does does not have a monitor, an {@code > IllegalMonitorStateException} is thrown. Suggestion: * it does not have a monitor, an {@code IllegalMonitorStateException} is thrown. src/java.base/share/classes/java/lang/Object.java line 347: > 345: * <div class="preview-comment"> > 346: * If this object is a {@linkplain > java.util.Objects#hasIdentity value object}, > 347: * it does does not have a monitor, an {@code > IllegalMonitorStateException} is thrown. Suggestion: * it does not have a monitor, an {@code IllegalMonitorStateException} is thrown. src/java.base/share/classes/java/lang/Object.java line 371: > 369: * <div class="preview-comment"> > 370: * If this object is a {@linkplain > java.util.Objects#hasIdentity value object}, > 371: * it does does not have a monitor, an {@code > IllegalMonitorStateException} is thrown. Suggestion: * it does not have a monitor, an {@code IllegalMonitorStateException} is thrown. src/java.base/share/classes/java/lang/Object.java line 402: > 400: * <div class="preview-comment"> > 401: * If this object is a {@linkplain > java.util.Objects#hasIdentity value object}, > 402: * it does does not have a monitor, an {@code > IllegalMonitorStateException} is thrown. Suggestion: * it does not have a monitor, an {@code IllegalMonitorStateException} is thrown. src/java.base/share/classes/java/lang/Object.java line 523: > 521: * <div class="preview-comment"> > 522: * If this object is a {@linkplain > java.util.Objects#hasIdentity value object}, > 523: * it does does not have a monitor, an {@code > IllegalMonitorStateException} is thrown. Suggestion: * it does not have a monitor, an {@code IllegalMonitorStateException} is thrown. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31120#discussion_r3397207350 PR Review Comment: https://git.openjdk.org/jdk/pull/31120#discussion_r3397208540 PR Review Comment: https://git.openjdk.org/jdk/pull/31120#discussion_r3397209427 PR Review Comment: https://git.openjdk.org/jdk/pull/31120#discussion_r3397210178 PR Review Comment: https://git.openjdk.org/jdk/pull/31120#discussion_r3397211105
