On Sun, 19 Jul 2026 11:37:49 GMT, Dingli Zhang <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Use print_debug() when encountering unknown DWARF operations
>> - Add onAttach() to LinuxDebuggerLocal to execute platform-dependent process
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotAgent.java line
> 563:
>
>> 561: } else if (cpu.equals("ppc64")) {
>> 562: machDesc = new MachineDescriptionPPC64();
>> 563: } else if (cpu.equals("aarch64")) {
>
> Nit: This check is now unreachable dead code since it's already handled by
> the outer if. Could you remove it?
Good catch! Removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31669#discussion_r3611717046
