On Fri, 26 Jun 2026 21:42:57 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Use print_debug() when encountering unknown DWARF operations
>>  - Add onAttach() to LinuxDebuggerLocal to execute platform-dependent process
>
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 231:
> 
>> 229:       default:
>> 230:         if (!process_arch_specific_dwarf_instructions(op)) {
>> 231:           print_debug("DWARF: Unknown opcode: 0x%x\n", op);
> 
> print_error

I reverted this change to use `print_debug()` because I saw new error at 
TestJhsdbJstackMixedWithXComp.java on AArch64 (both with/without PAC). It 
reported `DW_CFA_offset_extended` is not supported.

As you know SA haven't yet supported all of DWARF instructions, so this message 
could cause test failure if it appears in stderr. So I think it is better to 
keep `print_debug()` here.
(I will implement `DW_CFA_offset_extended` (and other DWARF instructions if 
there are any others) as another issue(s) after this PR)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31669#discussion_r3488890371

Reply via email to