On Wed, 12 Aug 2026 02:21:46 GMT, Vladimir Kozlov <[email protected]> wrote:
>> src/hotspot/share/c1/c1_LIRGenerator.cpp line 3852:
>>
>>> 3850: if (AOTCodeCache::is_dumping_code()) {
>>> 3851: counter_holder = new_register(T_METADATA);
>>> 3852: __ metadata2reg(counters_adr->constant_encoding(),
>>> counter_holder);
>>
>> I think we can do this in the general case as well. No only with
>> `AOTCodeCache::is_dumping_code()`.
>
> Thank you, @veresov. I will file RFE for mainline.
I misunderstood you. You are suggesting change in PR and not extract this code
and push it separately.
Yes, we can do this later as cleanup after these PR are integrated. I prefer to
not make changes anymore here, unless it is bug fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r3769142839
