On Mon, 20 Apr 2026 17:20:13 GMT, Ioi Lam <[email protected]> wrote:

>> Improve startup and warmup time by making optimized native code for an 
>> application instantly available when the HotSpot Java Virtual Machine 
>> starts. Achieve this by compiling application code to native code in a 
>> training run, storing the native code in the [AOT 
>> cache](https://openjdk.org/jeps/483#Description) for use in subsequent 
>> production runs.
>> 
>> More details in the [JEP](https://openjdk.org/jeps/544).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/hotspot/share/cds/cdsConfig.cpp line 135:
> 
>> 133:     // UPDATE: disabled for performance - by default small Java heaps 
>> are used
>> 134:     // AOT code will be rejected if oops encoding does not match
>> 135:     FLAG_SET_ERGO_IF_DEFAULT(UseCompatibleCompressedOops, true);
> 
> The comment doesn't seem to match the code. Should the comment be removed?

Yes. It should be removed.

> src/hotspot/share/cds/cds_globals.hpp line 181:
> 
>> 179:                                                                         
>>     \
>> 180:   product(bool, SkipArchiveHeapVerification, false, DIAGNOSTIC,         
>>     \
>> 181:           "Skip verification of CDS archive heap")                      
>>     \
> 
> Is this change necessary for AOT code?

No. I missed to remove it from my patch. I will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r3112552487
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r3252065142

Reply via email to