> Can I please get a review of this change which addresses the issue noted in 
> https://bugs.openjdk.org/browse/JDK-8391869?
> 
> The change now reduces the chances of the jtreg failure handler in the JDK 
> identifying an incorrect file as a core dump file. In theory, this check can 
> be made much more stricter but I didn't want add that complexity.
> 
> I've verified that with this change `.mdmp` and `core.<xxx>` files continue 
> to be considered as a core dump files and yet any JAR files that may have had 
> "core" in their file names are no longer considered as core dump files.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Jaikiran Pai has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains five additional commits since 
the last revision:

 - Erik's review
 - merge latest from master branch
 - merge latest from master branch
 - merge latest from master branch
 - 8391869: jtreg failure handler in the JDK incorrectly determines core dump 
files

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/32723/files
  - new: https://git.openjdk.org/jdk/pull/32723/files/0dc3f207..5f638c61

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=32723&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=32723&range=00-01

  Stats: 65412 lines in 1477 files changed: 38137 ins; 17543 del; 9732 mod
  Patch: https://git.openjdk.org/jdk/pull/32723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32723/head:pull/32723

PR: https://git.openjdk.org/jdk/pull/32723

Reply via email to