On Tue, 22 Sep 2026 06:25:47 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which addresses the issue noted in >> https://bugs.openjdk.org/browse/JDK-8391869? >> >> The change now reduces the chances of the jtreg failure handler in the JDK >> identifying an incorrect file as a core dump file. In theory, this check can >> be made much more stricter but I didn't want add that complexity. >> >> I've verified that with this change `.mdmp` and `core.<xxx>` files continue >> to be considered as a core dump files and yet any JAR files that may have >> had "core" in their file names are no longer considered as core dump files. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Erik's review > - merge latest from master branch > - merge latest from master branch > - merge latest from master branch > - 8391869: jtreg failure handler in the JDK incorrectly determines core dump > files This will be an improvement at least. If we need to refine further we can look at specific cases. Thanks for fixing. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32723#pullrequestreview-5274946417
