On Wed, 4 Nov 2026 02:00:13 GMT, Chris Plummer <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update. Includes reverting removal of DebuggingContext and error handling
>> in HotSpotVirtualMachineCoreDump.java
>
> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line 54:
>
>> 52: */
>> 53: @SuppressWarnings("restricted")
>> 54: public class VirtualMachineImpl extends HotSpotVirtualMachineLive {
>
> Have you considered renaming this to HotSpotVirtualMachineLiveImpl to be
> consistent with HotSpotVirtualMachineCoreDumpImpl?
I was not sure about changing the name of the existing class that was exposed
to apps, in case they are expecting such instances. Similarly to
AttachProviderImpl, that's the name some tools might be expecting to see. It's
not a public API but maybe such a change could be a problem.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r4471171425
