On Wed, 4 Nov 2026 01:58:09 GMT, Chris Plummer <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update. Includes reverting removal of DebuggingContext and error handling >> in HotSpotVirtualMachineCoreDump.java > > src/jdk.attach/share/native/revivalhelper/revival.hpp line 117: > >> 115: // >> 116: >> 117: // One structure to keep in sync with the JVM: > > Why not a common header file so only one copy is needed? I was concerned with having source in one module reach into another module for the shared header... jdk.attach to hotspot or vice-versa. I thought that would look wrong, unless there is some valid way of sharing. > src/jdk.attach/share/native/revivalhelper/revival.hpp line 118: > >> 116: >> 117: // One structure to keep in sync with the JVM: >> 118: #define REVIVAL_MAGIC 0x2e6e656b6e617266 > > What's the origin of this? Seems a version number that gets incremented with > every edit would be better. Yes the structure has a version and a length as well, so maybe that is enough to verify it, I could remove this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r4469066198 PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r4469087384
