On Wed, 4 Nov 2026 02:15:37 GMT, Chris Plummer <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update. Includes reverting removal of DebuggingContext and error handling
>> in HotSpotVirtualMachineCoreDump.java
>
> src/hotspot/share/services/diagnosticCommand.cpp line 573:
>
>> 571: if (Thread::is_revived() && _locks.value()) {
>> 572: // In VMThread, VM_PrintThreads::doit_prologue is not called.
>> 573: Heap_lock->lock();
>
> Is this still needed now that DebuggingContex is back in?
Right, it was trying without asserts disabled that discovered this, it is no
longer required.
It could be considered more correct to keep it in, although with jcmd on cores
there is no other thread to race against.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r4470194845
