On Sun, Apr 18, 2010 at 8:26 AM, Rob Landley <[email protected]> wrote: >> Nguyễn Thái NgỠc Duy (39): >> ar: do not filter listing if there is no extra argument >> >> This is a regression, not related to Windows port at all. >> >> Config.in: add target platform selection >> Config.in: add target platform WIN32 > > No. You don't have to config busybox for arm or mips or powerpc, you just > build it. The compiler defines macros that tell you what target you're > building on. For example, on Linux there's: > > #define __linux__ 1 > > Do this: > > gcc -dM -E - < /dev/null
That does not help at kconfig level. I need to filter out applets that I know they will never work (or won't work for the moment). It's the next patch that you object. >> Config.in: disable all commmands when TARGET_WIN32 is selected > > So you're forcing the rest of us to carry annotations on every single command > ever about what you do and don't support. > > Why is this our problem? I also force you to carry lots of workaround just for Windows. But on the other hand, it's isolated in win32 subdirectory. As for Config.in, I don't think you need to care about those "depends on !MINGW32" (or alike) lines. If it's really a problem, do you have any suggestions? My last approach would be maintaining them out of mainline, what I am doing now. I hope there is a better way than that. >> win32: Refuse to build on Windows/MinGW unless TARGET_WIN32 is >> selected > > Wrong. If you read the patch, you would see that it only refuses to build you you do use MinGW compiler and not have TARGET_WIN32 set. >> Very basic stuff just enough to make a succesful build. You >> will have a nice 52K busybox.exe, with no applets. > > On Linux, or allnoconfig is 10k. (I'm not sure _why_ it's 10k, I thought it > used to be more like 5k, but oh well...) Well, size does not matter that much to me, at least for now. Who knows, I might do size optimization someday if its functionality is good enough. -- Duy _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
