----- Original Message -----
From: <[EMAIL PROTECTED]>
> vmassol 02/03/10 05:28:19
>
> Modified: anttasks build.xml
> anttasks/src/java/org/apache/cactus/ant
> RunServerTestsTask.java StartServerHelper.java
> StopServerHelper.java
> Removed: anttasks LICENSE
> Log:
> second part of build process refactoring
While I'm at it, I'll make a suggestion or two below...
>
========================================================================
> + Base directory for all file related operations
> +
========================================================================
> + -->
> + <property name="base.dir" value="anttasks"/>
> +
Ant already has a ${basedir} - seems confusing to make up your own for such
purposes. I don't quite know what all you're refactoring, I just thought
I'd mention the potential confusion I see.
But on a different point, how about using 'location' instead of 'value' for
<property> when setting properties that refer to directories or files? The
nice thing about that is that it resolves the property to be the absolute
path to the file/directory making it much more pleasant to send to other
build files that don't know the relative position and such.
Erik
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
