Thinking more about it : * I cannot replace my base.dir by basedir as I need basedir to remain constant whereas base.dir changes for each subproject. I agree, I should call it differently (although I think Ant should prefix all its internal properties by "ant.", exactly for this reason).
* WRT "location" for <property> : The majority of my properties that relate to files are located in build.properties. Thus, I imagine they will be loaded by Ant in the same way as if I had used "value", right ? Thanks -Vincent > -----Original Message----- > From: Erik Hatcher [mailto:[EMAIL PROTECTED]] > Sent: 10 March 2002 19:17 > To: Cactus Developers List > Subject: Re: cvs commit: jakarta- > cactus/anttasks/src/java/org/apache/cactus/ant RunServerTestsTask.java > StartServerHelper.java StopServerHelper.java > > ----- Original Message ----- > From: <[EMAIL PROTECTED]> > > vmassol 02/03/10 05:28:19 > > > > Modified: anttasks build.xml > > anttasks/src/java/org/apache/cactus/ant > > RunServerTestsTask.java StartServerHelper.java > > StopServerHelper.java > > Removed: anttasks LICENSE > > Log: > > second part of build process refactoring > > While I'm at it, I'll make a suggestion or two below... > > > > ======================================================================== > > + Base directory for all file related operations > > + > ======================================================================== > > + --> > > + <property name="base.dir" value="anttasks"/> > > + > > Ant already has a ${basedir} - seems confusing to make up your own for > such > purposes. I don't quite know what all you're refactoring, I just thought > I'd mention the potential confusion I see. > > But on a different point, how about using 'location' instead of 'value' > for > <property> when setting properties that refer to directories or files? > The > nice thing about that is that it resolves the property to be the absolute > path to the file/directory making it much more pleasant to send to other > build files that don't know the relative position and such. > > Erik > > > > -- > To unsubscribe, e-mail: <mailto:cactus-dev- > [EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:cactus-dev- > [EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
