> -----Original Message-----
> From: Erik Hatcher [mailto:[EMAIL PROTECTED]]
> Sent: 10 March 2002 19:17
> To: Cactus Developers List
> Subject: Re: cvs commit: jakarta-
> cactus/anttasks/src/java/org/apache/cactus/ant RunServerTestsTask.java
> StartServerHelper.java StopServerHelper.java
>
> ----- Original Message -----
> From: <[EMAIL PROTECTED]>
> > vmassol 02/03/10 05:28:19
> >
> > Modified: anttasks build.xml
> > anttasks/src/java/org/apache/cactus/ant
> > RunServerTestsTask.java
StartServerHelper.java
> > StopServerHelper.java
> > Removed: anttasks LICENSE
> > Log:
> > second part of build process refactoring
>
> While I'm at it, I'll make a suggestion or two below...
please continue ! :-)
>
> >
>
========================================================================
> > + Base directory for all file related operations
> > +
>
========================================================================
> > + -->
> > + <property name="base.dir" value="anttasks"/>
> > +
>
> Ant already has a ${basedir} - seems confusing to make up your own for
> such
> purposes. I don't quite know what all you're refactoring, I just
thought
> I'd mention the potential confusion I see.
Hehe ... The thought occurred to me today ... I should change the name.
My base.dir points to the location of where the project to build is
located (and not the full path to where the build.xml basedir is). I
need this because I have higher level scripts calling subproject scripts
and I want everyone to have the same basedir so that I can pass relative
paths from the top level build.properties to subproject build.xml
scripts ...
I guess I could remove base.dir and use ${basedir} as a prefix to all
the subproject file paths. That would use one less property and avoid
the confusion. I'll put in my todo and will do it once I have finished
committing all the new stuff ...
>
> But on a different point, how about using 'location' instead of
'value'
> for
> <property> when setting properties that refer to directories or files?
> The
> nice thing about that is that it resolves the property to be the
absolute
> path to the file/directory making it much more pleasant to send to
other
> build files that don't know the relative position and such.
Ahah. Good idea. I hadn't realized this. Will do that as soon as I have
finished the refactoring.
Thanks a lot,
Keep sending suggestion !
I'm also very much interested in your feedback on the new build process
(I sincerely hope it is not too much complicated and that I am doing it
the right way as I have spent about 2 full days on it !).
I should have finished committing stuff within 1 hour or so.
Thanks.
-Vincent
>
> Erik
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
