Hi All,

First: Peter: great work!

Let me first state that I did *not* look at Peter's work yet - I'm 
unfortunately too busy
atm.

Nevertheless, since I've worked on maven2 integration/conversion, I wanted to 
bring up
some points that maybe not everybody is aware of. Do with this information what 
you
want but I thought I should just bring this up for completeness.

I already converted cactus to maven2 about 15 months ago. See [1]. This was done with symlinks, as discussed as a possible option at the time, to keep
the branch synchronized with the trunk without having to merge.
To fully apply that branch to trunk would require some moving of 
directories/source folders
in trunk.

Build-wise it looks like I took a slightly different approach, using profiles for the various J2EE versions - nothing like uberjar. Also I had to move some directories,
but it looks like Peter tried to keep the original structure intact (re. the 
problem
with maven only supporting one source tree per project - but again, I didn't look).
Also, about the maven2 plugin: I haven't looked at the code, but I'm the 
original author
of the maven-antrun-plugin and the maven-ant project, which is meant to easily 
integrate
ant tasks in maven 2 plugins. I used this approach to create the 
maven-xdoclet-plugin,
by internally registering and creating the xdoclet ant tasks. The 
<configuration>
tag would be filled with typical ant tasks for the xdoclet stuff.
I intended to take the same approach with the cactus plugin, which would be the 
easiest
and simplest way to implement a maven2 plugin. I don't know what the status is with the maven-cactus-plugin or wheter your approach
is similar, but I just wanted to get you this info.

Hope any of this is useful.

Thanks,

        Kenney


[1] 
https://svn.apache.org/repos/asf/jakarta/cactus/branches/CACTUS_TRUNK_MAVEN2_BRANCH

Magnus Grimsell wrote:
[snip]
Magnus hi,

I submitted a patch about the cactus-m2 integration in the jira, but it is
really outdated.

Please consider checking out the latest from the sourceforge repository:

svn co https://mamouth.svn.sourceforge.net/svnroot/mamouth/Cactuscactus-trunk


I checked out the following url:
https://mamouth.svn.sourceforge.net/svnroot/mamouth/Cactus


I think that the Cargo-0.9-SNAPSHOT dependency is needed - as the cactus-ant

integration is refactored to use some of the cargo classes (like WebXml.java,
EjbRef.java, etc).
But I spoke with the cargo guys, and they said that cargo would be released
soon. So I think that
this won't be a big problem.

The fact that you refactored Cactus to use Cargo 0.9 was the reason that I used
your code base for my patch. I've done some minor changes to Cargo that I 
needed.
So, once again. Great work :)

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to