Hi William, the updated webrev looks good, I have just two nits - please see below. No need for additional code review round.
Thank you, Jan target_discovery.c ------------------ I think line 743 can be removed, since errno is cleared for strtol(3C) purposes on line 734. orchestrator_api.h ------------------ I can see that following nit was not addressed (perhaps due to the oversight): 171 uint8_t partition_id; /* fdisk id (1-36) */ -> 171 uint8_t partition_id; /* fdisk id: 1 - (FD_NUMPART + MAX_EXT_PARTS) */ William Schumann wrote: > Resubmitting code review request after implementing changes previously > reviewed, > plus fix for: > [Bug 12137] Can not boot to grub when install AI to extended partition > with existing Windows partition > http://defect.opensolaris.org/bz/show_bug.cgi?id=12137 > The ICT that was changing the active partition flag should not do so > for logical partitions. > > Updated webrev: http://cr.opensolaris.org/~wmsch/bug-1777/ > > Old webrev: http://cr.opensolaris.org/~wmsch/bug-1777/1stwebrev/ > > Thank you, > William > >
