William Schumann wrote: > Instead, please look for the slim_source code webrev in the public > location: > http://cr.opensolaris.org/~wmsch/extended_partition/ > William > > jeanm wrote: >> >> Please review the following for the installation on extended >> partitions project: >> >> For the ON gate (questions should be directed to Ginnie Wray): >> >> http://cr.opensolaris.org/~ginnie/libdisk3/ >> >> >> For the slim_source gate (questions for libtd to Ginnie, rest of the >> code questions should be directed to William Schumann) >> >> file:///net/indiana-build.central/export/home/ws199450/extp/webrev/index.html >> >> >> >> >> Please respond by COB on Friday October 16. >> >> Thanks, >> >> Jean McCormack >> >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss William:
usr/src/cmd/auto-install/auto_install.c: 488: Can you print "true" or "false" based on the value of 'partition_is_logical' to make the output more readable? usr/src/cmd/auto-install/auto_parse.c: 35: You don't need to include sys/dktp/fdisk.h, it is included in liborchestrator_api.h, which is included in auto_install.h 269, 273: The debug statements look similar (not same). Do you need both? 264, 313, 434: Do you really want to exit if errno != 0? Why can't you set errno = 0 before calling strtoull(). The man page to strtoull() recommends setting errno to 0 before calling the function. 828-834: The code looks ok. Can you add a comment indication what will be the command issued in the case of logical partition? usr/src/lib/liborchestrator/disk_parts.c: 406: Do you want to check whether committed_disk_target and committed_disk_target->dparts before using it? 440: Same comment as that of 406 443: Do you disallow SUNIXOS even it is a Solaris partition (and not Linux Swap)? usr/src/lib/liborchestrator/orchestrator_api.h: 299, 183: Why can't you use Om_NUMPART in line 183? - Sundar
