Hi Sundar - Thank you very much for the code review. See my comments below.....
ginnie On 10/15/09 17:26, Sundar Yamunachari wrote: > William Schumann wrote: >> Instead, please look for the slim_source code webrev in the public >> location: >> http://cr.opensolaris.org/~wmsch/extended_partition/ >> William >> >> jeanm wrote: >>> >>> Please review the following for the installation on extended >>> partitions project: >>> >>> For the ON gate (questions should be directed to Ginnie Wray): >>> >>> http://cr.opensolaris.org/~ginnie/libdisk3/ >>> >>> >>> For the slim_source gate (questions for libtd to Ginnie, rest of the >>> code questions should be directed to William Schumann) >>> >>> file:///net/indiana-build.central/export/home/ws199450/extp/webrev/index.html >>> >>> >>> >>> >>> Please respond by COB on Friday October 16. >>> >>> Thanks, >>> >>> Jean McCormack >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > Ginnie, > > This is for the ON gate code review > > usr/src/lib/libdiskmgt/Makefile: > > 22: Update the copyright to 2009 Done > > usr/src/lib/libdiskmgt/common/partition.c: > > 606: Check the return value from malloc() and make sure that it is not > null Done > 612: free the allocated 'device' before continue Done > > - Sundar > > >
