Jedy Wang wrote: > Hi all, > > Please review the fix for the following bugs: > http://defect.opensolaris.org/bz/show_bug.cgi?id=4499 - At language > screen, when selecting "No default language support", nothing are shown > in Territory combox > > http://defect.opensolaris.org/bz/show_bug.cgi?id=4500 - When selecting > "No default language support", /LANG="C/POSIX" is set etc/default/init > > Webrev at http://cr.opensolaris.org/~jedy/44994500/ > > usr/src/cmd/gui-install/src/language-screen.c > Fixes 4499. If locale_name do not have (), return the whole string. Also > rename get_locale_name to get_locale_desc because the original name is > misleading.
That's definitely helpful to have the name changed. It was a bit confusing that it was indeed getting the locale description and not the name. :-) > > usr/src/cmd/gui-install/src/orchestrator-wrappers.c > Fixes 4500. Change locale_name from "C/POSIX" to C because this will be > passed to /etc/default/init as the default locale. Also remove N_() > because this string do not need to be translated. I was originally a bit confused here, I think partially because of the get_locale_name() call in language-screen.c that you're already renamed. Basically if we have the cposix locale it's name is now "C", the description returned is "C/POSIX" and this is what gets passed into gtk_list_store_set() etc... Thank you for the explanations and walking me through it. The changes look fine to me. One minor nit for these files overall is that they're generally missing comments for the functions, letting us know what they do. It might be useful as we fix bugs in these files to add a function comment block to the functions we touch. This is definitely not required for this fix it just seemed like something it would be helpful to do for any of us working in these files. Thanks again! -evan > > Regards, > > Jedy > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
