Evan Layton wrote: > Dave Miner wrote: >> Evan Layton wrote: >>> Hi Dave, >>> >>> These two bugs were created to split up the two issues described in >>> 3542 which is a stopper because of the error output it causes. Since >>> 3542 is a stopper and it?? marked as dependent on 4499 and 4500 do >>> those need to be marked as stoppers before the fix can be pushed? >>> >> >> Why wasn't it just fixed as 3542? That's what should have been done, >> and is easy to clean up with a recommit before pushing. > > Jedy had filed these and come up with a fix before we had a chance to > really sync up last night. I guess what could be done is close 4499 and > 4500 as duplicates of 3542 and do the push for that bug only. >
Please do. Dave > -evan > >> >> Dave >> >> >>> Thanks, >>> -evan >>> >>> jan damborsky wrote: >>>> Hi Jedy, >>>> >>>> three reviewers are sufficient, as at least two are required. >>>> The gate is open for pushes, but only stoppers can be integrated >>>> at this point . >>>> Please check with Dave Miner, if the bugs in question are >>>> considered to be stoppers for 2008.11. >>>> >>>> Thanks, >>>> Jan >>>> >>>> >>>> Jedy Wang wrote: >>>>> I have already had 3 reviewers. Do I need someone to open the gate for >>>>> me? >>>>> >>>>> Regards, >>>>> >>>>> Jedy >>>>> On Tue, 2008-11-04 at 14:24 +0800, Jedy Wang wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> Please review the fix for the following bugs: >>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4499 - At language >>>>>> screen, when selecting "No default language support", nothing are >>>>>> shown >>>>>> in Territory combox >>>>>> >>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4500 - When >>>>>> selecting >>>>>> "No default language support", /LANG="C/POSIX" is set >>>>>> etc/default/init >>>>>> >>>>>> Webrev at http://cr.opensolaris.org/~jedy/44994500/ >>>>>> >>>>>> usr/src/cmd/gui-install/src/language-screen.c >>>>>> Fixes 4499. If locale_name do not have (), return the whole >>>>>> string. Also >>>>>> rename get_locale_name to get_locale_desc because the original >>>>>> name is >>>>>> misleading. >>>>>> >>>>>> usr/src/cmd/gui-install/src/orchestrator-wrappers.c >>>>>> Fixes 4500. Change locale_name from "C/POSIX" to C because this >>>>>> will be >>>>>> passed to /etc/default/init as the default locale. Also remove N_() >>>>>> because this string do not need to be translated. >>>>>> >>>>>> Regards, >>>>>> >>>>>> Jedy >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> caiman-discuss mailing list >>>>>> caiman-discuss at opensolaris.org >>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>> >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >
