Hi Jedy, These two bugs are really duplicates of the two issues described in 3542 and 3542 is the stopper. Because of this and comments from Dave I've marked 4499 and 4500 as duplicates of 3542. I've also set you as the assignee for 3542 since you came up with the fix and have gone through the code review, etc. When doing the push for this fix we should use 3542 for the commit comment. If the commit has already been done it may be necessary to do the re-commit that Dave mentioned.
Thanks! -evan jan damborsky wrote: > Hi Jedy, > > three reviewers are sufficient, as at least two are required. > The gate is open for pushes, but only stoppers can be integrated > at this point . > Please check with Dave Miner, if the bugs in question are > considered to be stoppers for 2008.11. > > Thanks, > Jan > > > Jedy Wang wrote: >> I have already had 3 reviewers. Do I need someone to open the gate for >> me? >> >> Regards, >> >> Jedy >> On Tue, 2008-11-04 at 14:24 +0800, Jedy Wang wrote: >> >>> Hi all, >>> >>> Please review the fix for the following bugs: >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4499 - At language >>> screen, when selecting "No default language support", nothing are shown >>> in Territory combox >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4500 - When selecting >>> "No default language support", /LANG="C/POSIX" is set etc/default/init >>> >>> Webrev at http://cr.opensolaris.org/~jedy/44994500/ >>> >>> usr/src/cmd/gui-install/src/language-screen.c >>> Fixes 4499. If locale_name do not have (), return the whole string. Also >>> rename get_locale_name to get_locale_desc because the original name is >>> misleading. >>> >>> usr/src/cmd/gui-install/src/orchestrator-wrappers.c >>> Fixes 4500. Change locale_name from "C/POSIX" to C because this will be >>> passed to /etc/default/init as the default locale. Also remove N_() >>> because this string do not need to be translated. >>> >>> Regards, >>> >>> Jedy >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
