Hi, The code looks good to me. As for the format problem, I prefer to leave them alone.
Regards, Jedy On Aug 6, 2009, at 6:38 PM, Matt Keenan wrote: > > Appreciate the review. > > These indentation nits have always been in the gui code and were > allowed partly > because of the long names of GTK variables and API. > > The nits in the areas where I've changed the code were always there, > i did > not introduce them :). > > e.g. > 375 : line > 80 chars > > This is reported because the start of the line uses TAB chars which > are counted > as 8 spaces. > > TAB chars are used extensively throughout the GUI code, to attempt > to resolve > this would require changing quite a lot of code. > > To change in one place and leave the rest untouched does not make > sense to me. > So the choice's are : > > 1. Change all gui source to try and resolve as many nits as possible > 2. Change source files that I am touching as I go and attempt to > resolve as > many nits as possible, bear in mind all nits will not be possible > to > resolve. > 3. Leave code as is. > > I'm happy with whatever choice is made... 3. of course is the least > work for me :) > > cheers > > Matt > > Joseph J. VLcek wrote: >> Matt Keenan wrote: >>> Both these bugs are L10n related bugs thus bundling fix for both >>> in single review/commit. >>> >>> Certain strings within GUI installer are not being extracted for >>> localization. >>> Solution is simply to wrap these strings with _() and N_() macro's. >>> >>> Fixes bugs : >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=8786 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=8788 >>> >>> Webrev : >>> http://cr.opensolaris.org/~mattman/bugs-8786-8788/ >>> >>> Cheers >>> >>> Matt >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> Hey Matt; >> Regarding: users-screen.c >> Just a nit. The indentation around the code you've changed does not >> appear to be correct. There is an extension to the hg command set, >> "hg nits". It's available on indiana-build.sfbay. You need to run >> "hg nits" in your workspace repository. It will report incorrect >> coding conventions and indentation issues. >> Joe > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
