Dave Miner wrote: > Frank Ludolph wrote: >> >> >> Jedy Wang wrote: >>> The withdraw is temporary which means it will not be committed into >>> May release. If the patch is reviewed, I will committed the patch >>> after May release. >> I agree that 1075 isn't critical for May, but I think this one should >> go in. It is very disorienting when the user magnifies the map and >> suddenly is somewhere very different. Virtually every user will >> experience this disorientation. >> > > As the rules I sent out yesterday said, you can nominate a bug you > think is a blocker, and we'll discuss it. I'm certainly sympathetic > to the issue here. I nominate 1074 as a blocker. > > Relatedly, I'm still seeing the timezone screen end up with a vertical > scroll bar in the test images even after the recent changes. So I > think we're going to need to make some fixes here anyway; if this > one's low risk I'd likely take it, too.
I noticed it too. This is because I asked Jedy to size the width of the initial (shrunken) map to fit the width of the subwindow with a small top/left/right margin. Due to the map's aspect ratio, the height at this size pushes the controls below the map down far enough that the date/time clipped by the bottom of the subwindow and so the vertical scrollbar, even with the font size now being correct. The way to fix this would be to shrink the map even more until there is no vertical scrollbar. This is something of a trial and error fitting. The initial map would then have wide left and right margins, but this is probably better than a vertical scrollbar. This new, reduced height will need to be maintained when the map expands. This would be a new bug which would also be nominated as a blocker. Frank
