Hi Jedy, Changing the zoom in scale to 3.0 is a UI behavioural change. I'm not sure we should be doing this at such a late stage, certainly not without getting Frank's feedback first. From reading Dave's comments also, I think his intention was that this is something we should consider in the future, not something we need to do right now. My feeling would be not to make this change unless Frank specifically requests it.
Thanks, Niall. Jedy Wang wrote: > Hi Dave, > > Thanks for your review. I just updated the webrev and added some > comments to the new function. I also changed zoom-in scale to 3.0. > Hope this will be better. > You can find the webrev at > http://cr.opensolaris.org/~jedy/bug-1074-new and latest binaries at > /net/fulltime.prc/export/home/share/gui-install.tar.gz. > > And I will file another patch to fix the code style problem after May > release. > > Regards, > > Jedy > On Fri, 2008-04-11 at 12:04 -0400, Dave Miner wrote: >> Jedy Wang wrote: >> > Hi all, >> > >> > The patch is updated. New webrev of changes is at: >> > http://cr.opensolaris.org/~jedy/bug-1074-new >> > <http://cr.opensolaris.org/%7Ejedy/bug-1074-new> >> > <http://cr.opensolaris.org/~jedy/bug-1075-new >> > <http://cr.opensolaris.org/%7Ejedy/bug-1075-new>> >> > >> > The patch includes the changes to date-time-zone.glade which is to >> > remove the vertical scorllbar in date time screen. Because some unused >> > widgets, such as timezonealign, are removed, datetimezone-screen.[ch] >> > are updated accordingly. >> > >> > This patch also fixes a problem in the original patch. The old patch can >> > not handle resized window. If the window is large enough and white >> > margin is added to the left/right side of the map, the map is still >> > scrolled to wrong place. New patch fixed this problem. >> > >> >> map.c >> Please add some comments to the new function to explain what it's doing >> along the way. >> >> timezone.c >> I'd really like to see more effort to conform to the Sun C style >> guidelines, though that's an issue for another time, I guess. The >> inconsistency of indentation makes the code look alarmingly disorganized. >> >> 622: the comment really should precede the conditional at 618, or if you >> want to leave it here then it should reverse its sense to indicate that >> we missed a city and are zooming, since once we're inside this block, >> we're going to zoom. >> >> > If you want to have a try. You can find the latest binary of gui-install >> > at /net/fulltime.prc/export/home/share/gui-install.tar.gz. >> > 1) gtar zxvf gui-install.tar.gz >> > 2) cp gui-install /usr/share/ >> > 3) run /usr/share/bin/gui-install >> > >> >> Thanks for providing this wad to check it out, I patched it into an RC0 >> image with lofs and I think it works quite a bit better. >> >> One general comment is that we may need to support a higher zoom level >> at some point; the Caribbean islands are still basically all on top of >> each other. >> >> Dave >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org <mailto:caiman-discuss at opensolaris.org> >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
