Sue, thanks for review !
Jan Susan Sohn wrote: > Thanks, Jan, looks good now. > > Sue > > On 04/22/09 06:44, jan damborsky wrote: >> Hi Sue, >> >> thank you very much for your comments. >> Please see my response in-line. >> The webrev has been updated accordingly. >> >> Jan >> >> >> >> On 04/22/09 15:29, Susan Sohn wrote: >>> Hi Jan, >>> >>> Just some minor comments on the updated webrev: >>> >>> setup-sparc >>> ----------- >>> 92 (nit) >>> referred -> referenced >>> or you could also use >>> referred -> pointed to >> >> Changed. >> >>> >>> 240-245 Perhaps change the wording of: >>> >>> "Service $srv_dfl is currently used by SPARC" \ >>> "clients not explicitly associated with another" \ >>> "service by the use of the 'create-client' subcommand" >>> >>> to >>> >>> "Service $srv_dfl is currently being used by SPARC" \ >>> "clients which have not explicitly been associated with another" \ >>> "service via the 'create-client' subcommand." >> >> Changed. >> >>> >>> and (nit) add a comma after clients in: >>> >>> "To select service $svc_name for those SPARC clients" \ >>> "use the following commands:" >> >> Changed. >> >>> >>> >>> setup-service >>> ------------- >>> 259,268,273 Sparc-> SPARC >> >> Changed. >> >>> >>> Thanks, >>> Sue >>> >>> >>> >>> On 04/21/09 04:39, jan damborsky wrote: >>>> Hi, >>>> >>>> could I please ask two people for reviewing changes for following >>>> blocker ? >>>> >>>> 8262 'installadm create-service' shouldn't overwrite >>>> /etc/netboot/wanboot.conf for Sparc, but notify user instead >>>> >>>> webrev: >>>> http://cr.opensolaris.org/~dambi/bug-8262 >>>> >>>> Thank you very much, >>>> Jan >>>> >>>> >>>> modules affected: >>>> ----------------- >>>> * installadm tools (Sparc platform) >>>> >>>> testing done - please see attached test procedures >>>> --------------------------------------------------- >>>> >>>> >>>> ------------------------------------------------------------------------ >>>> >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >
