On Mon, 17 Dec 2007, Jean McCormack wrote: > I hate to nitpick..... > > But the comment in main.c says " > > * The first time we are called, attempt to dlopen() > * libz.so.1 and get a pointer to the compress2() function > > But the code does a dlopen(LIBZ) and LIBZ is defined as libz.so > > I know they are usually (always?) the same but can you just make this > consistent?
Yep, I'll make it consistent. > utils.c > lib_hdl.... I'm not fond of the way you manipulate lib_hdl. You declare it in > utils.c > and set it in openlib. Then return it from openlib to main.c. But closelib > takes > the value from where you set it in openlib. Why not 1) make it a global or 2) > pass it around > instead of this funky mix? If others are OK with this style I won't hold it > up though. I debated making it a global but then decided against it, left it local to utils.c since that's the only place it gets set. I can make it a global if others feel strongly about it too. > Did you ever resolve Tim's issues with die? I thought you were doing to do a > dlerror and exit instead of > die? Maybe I misunderstood? So, with the new error messages I've gotten rid of strerror(errno) in die() altogether. This resolves Tim's issue. Thanks for the review one more time. Alok
