Dave Miner wrote: > Ethan Quach wrote: >> Dave, >> >> orchestrator_private.h >> ---------------------- >> 133 - There shouldn't be a space in there should there? >> > > No, it's correct; if you don't have a K&R handy, see > http://en.wikipedia.org/wiki/C_syntax#String_literal_concatenation > >> perform_slim_install.c: >> ----------------------- >> 701 - Missing the %s at the end of the string. > > There's no form of printf involved, it's just more concatenation as above...
Ah, okay. > >> 1919 - Need a space before "root" >> > > OK, will fix. Thanks, -ethan > > Thanks, > Dave > > >> Other than that, looks fine. >> >> >> -ethan >> >> >> Dave Miner wrote: >>> Caimaniacs, >>> >>> Please review the following webrev's which address: >>> >>> 137 shorter, shared name for default root pool >>> 216 installer should take snapshots after installation >>> 347 SUNWinstall in slim_source doesn't build on Indiana >>> >>> http://cr.opensolaris.org/~dminer/bug_216/ >>> http://cr.opensolaris.org/~dminer/slim_prototype_137/ >>> >>> These are targeted for the next preview release, so I'd appreciate >>> review in the next day or so. >>> >>> Dave >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
