Hi Dave, I have one comment/question:
usr/src/lib/liborchestrator/orchestrator_private.h* *ROOTPOOL_SNAPSHOT is defined as ROOTPOOL_NAME "@install". There is a space between ROOTPOOL_NAME and @install. I think it is compiler independent as to whether the space gets stripped. I looked at the "zfs" man page, it says snapshot should be followed by filesystem at name or volumne at name. It doesn't say about having a space before the "@" sign is ok or not. All other changes look good to me. Thanks, --Karen Dave Miner wrote: > Caimaniacs, > > Please review the following webrev's which address: > > 137 shorter, shared name for default root pool > 216 installer should take snapshots after installation > 347 SUNWinstall in slim_source doesn't build on Indiana > > http://cr.opensolaris.org/~dminer/bug_216/ > http://cr.opensolaris.org/~dminer/slim_prototype_137/ > > These are targeted for the next preview release, so I'd appreciate > review in the next day or so. > > Dave > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
