Shawn Walker wrote: > On Jan 11, 2008 3:17 PM, Ethan Quach <ethan.quach at sun.com> wrote: >> Can someone do a review of this bugfix. Its targeted for the preview2 >> release, so a review in the next couple working days would be appreciated. > > A few comments. > > http://cr.opensolaris.org/~equach/webrev.354/usr/src/lib/liborchestrator/perform_slim_install.c.html > > 101 int zfs_fs_num = 1; > 102 int zfs_shared_fs_num = 2; > > Is there a reason that these are variables instead of #defines ?
No particular reason. These don't change so I suppose I can change them to #defines. > > Only other comment I have is the same as Cyril: is there a reason that > parts of the hierarchy name are all uppercase (e.g. "ROOT")? ROOT is uppercased because its a special dataset used by the BE management software. The uppercase for BE1 is just a random name of the initial BE. I'm fine with this being something else if you have a better suggestion. > > Otherwise, I think the changes are fine. Thanks for the review. -ethan
