Hi Jack, Thanks for your review. I agree that including the comment will make the file more complete. However, I tend to want to leave it out. This is because this particular change is just a temporary workaround. The real solution is to run the rtc command in a separate zone so nothing on the underlying system gets affected. I know that including the comment is just a simple series of "echo" statements, but I think it makes the code harder to read with these extra echo statements. For developers and hackers, they can easily just look up the same information from the rtc man page or the actual code itself.
Thanks, --Karen Jack Schwartz wrote: > Hi Karen. > > Functionally the changes look fine to me. > > My concern is that the comment at the beginning of the file is left > out. In order to give a more complete file, such as what the rtc > command generates, you may want to include it. It explains how the info > is used, which may be of interest to developers/hackers, who will be the > primary users of this script. From rtc.c, the comment is: > > static char zone_comment[] = > "#\n" > "# This file (%s) contains information used to manage the\n" > "# x86 real time clock hardware. The hardware is kept in\n" > "# the machine's local time for compatibility with other x86\n" > "# operating systems. This file is read by the kernel at\n" > "# boot time. It is set and updated by the /usr/sbin/rtc\n" > "# command. The 'zone_info' field designates the local\n" > "# time zone. The 'zone_lag' field indicates the number\n" > "# of seconds between local time and Greenwich Mean Time.\n" > "#\n"; > > Thanks, > Jack > > Karen Tung wrote: > >> Please do a review for fixing the following bug: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=349 >> >> The webrev is at: >> >> http://cr.opensolaris.org/~ktung/bug349/ >> >> Thanks, >> >> --Karen >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
