Hi Joe, I don't have any comment about the correctness of the changes.
I do have a comment about the "style" of changes to all_lang_slim_cd_x86.xml and slim_cd_x86.xml. The way you have things commented out right now makes it confusing for people to specify additional authorities. If they want to specify an additional publisher, they would have to uncomment the <post_install_repo_addl_authority> tag and the corsponding </post_install_repo_addl_authority> tag. However, the comment on there says to "uncomment this to use the contrib publisher...", which is not entirely correct, because they need to uncomment that to use other type of publisher too. I think it is more confusing to leave the contrib publisher there commented out. I think it would be much cleaner to just remove the contrib publisher from those 2 manifests. Thanks, --Karen On 02/22/10 14:33, Joseph J. VLcek wrote: > Please review the fixes for: > > Bug 14681 /contrib needs some alone time > http://defect.opensolaris.org/bz/show_bug.cgi?id=14681 > > The webrev is here: > http://cr.opensolaris.org/~joev/bug14681/ > > This is not a large code change. > > I have left the code in the manifest which would add the contrib repo > to the installed system but it is commented out. I have discussed this > approach with Ethan Quach and he is OK with it. > > Testing: > ----------- > I am in the process of testing by doing an AI and a LiveCD install on > x86. I will not push until my tests have completed. > > Thank you! > > Joe > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
