* Joseph J. VLcek (Joseph.Vlcek at Sun.COM) wrote: > On 02/22/10 05:33 PM, Joseph J. VLcek wrote: > >Please review the fixes for: > > > >Bug 14681 /contrib needs some alone time > >http://defect.opensolaris.org/bz/show_bug.cgi?id=14681 > > > >The webrev is here: > >http://cr.opensolaris.org/~joev/bug14681/ > > > >This is not a large code change. > > > >I have left the code in the manifest which would add the contrib > >repo to the installed system but it is commented out. I have > >discussed this approach with Ethan Quach and he is OK with it. > > > >Testing: > >----------- > >I am in the process of testing by doing an AI and a LiveCD > >install on x86. I will not push until my tests have completed. > > > >Thank you! > > > >Joe > > > > Glenn and Karen ... and anyone else interested... > > Thanks you for your feedbac. > I have also discussed this with Karen. > > Please review the updated, round 2 (_r2), webrev which addresses > the comments made by Glenn Lagasse and Karen Tung. > > > Found here: > http://cr.opensolaris.org/~joev/bug14681_r2/
Looks good to me. Ship it! -- Glenn
