Hi Glenn,
On Wed, 7 Apr 2010, Glenn Lagasse wrote:
Hey Alok,
* Alok Aggarwal ([email protected]) wrote:
Could I please get a review of the fixes for the
following defects -
15456 text install images with the default manifest don't build after push for
13276
15461 media-fs-root should request console access better
15463 text-mode-menu needs better console redirection handling
15529 Minor issues with fix for 15167
Webrev -
http://cr.opensolaris.org/~aalok/15456-15461-15463-15529/
text_mode_sparc.xml:
Looks good
text_mode_x86.xml:
Why not keep consistent with the SPARC media (OpenSolaris_Text_X86)?
I actually followed AI's lead here and went with the
naming convention in the AI DC manifests.
But I agree this would be clearer. Changed and webrev
updated.
Thanks for the review!
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
