Hi Keith,
On Wed, 7 Apr 2010, Keith Mitchell wrote:
Hi Alok,
First, in regards to the copyrights:
For the purposes of consistency with Sue's fix for 15511, and because the
text installer source files were originally available in an externally
visible gate in 2009 (even though that gate was not slim_source, it was still
a source code repository in use by OpenSolaris developers), please use the
"2009, 2010" format for the files modified that were introduced as part of
the text installer project.
Changed.
Additionally, as media-fs-root can be tracked in slim_source back to
live-fs-root, and that file has an original copyright date of 2008, so the
copyright for that file should be "2008, 2010". (Unless that file has been
around longer and that data can be readily tracked down, in which case use
the earliest appropriate date).
It dates back to atleast 2006 but I'm too lazy to
go hunting for a source repo dated 2006 to provide
evidence. And, since it really doesn't seem that
important per jbeck's mail, I'll stick with 2008.
The code itself looks fine, just a few nits:
text_mode_x86.xml:
For consistency with text_mode_sparc.xml, should the default distribution
name end in _x86? (i.e., "OpenSolaris_Text_x86")
Changed.
users.py:
Check alignment on lines 148, 170, 211.
Changed. Webrev updated.
Thanks for the review!
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
