Ethan,
On 04/ 9/10 02:00 PM, Ethan Quach wrote:
This fix is going into build 138, so please update the copyright
as noted per our gk's Heads-up mail:
http://www.opensolaris.org/jive/thread.jspa?threadID=127027&tstart=30
OK
ai_manifest.rng - 375 - A nit on the new tag name. Why not just
name it "on_existing"? That's not consistent with existing
tagging convention, but we need to change that anyhow.
So that users are not confused with inconsistent usage. When the
tagging convention changes, it should change uniformly.
auto_parse.c - 744-746 - For completeness, could you expand
this to an if/else clause that compares for all possible string
values here.
Typically, this is not done, since the code is unnecessary and would
change nothing, while consuming various resources. I might advocate
documenting code for completeness, but not coding for the sake of
completeness.
disk_slices.c - 470 - should just print out whatever the name of
the new tag name is here.
Tags are not normally logged; however, it seems like a good idea, so
will add it.
William
thanks,
-ethan
On 04/08/10 09:28, William Schumann wrote:
http://cr.opensolaris.org/~wmsch/bug-8661/
http://defect.opensolaris.org/bz/show_bug.cgi?id=8661
Added tag to AI manifest RNG schema ai_manifest.rng for slices:
slice_on_existing. Possible values:
"error" (default) - if a slice N already exists and is specified in a
slice create action, consider it a configuration error and terminate
the install to protect the slice.
"overwrite" - overwrite the existing slice N definition by first
deleting it in AI's internal representation of the VTOC, then
effecting the new slice creation.
Added new parameter to om_create_slice() to indicate the option.
Added default value to ai_manifest.defval.xml as array placeholder
(the usual workaround).
Implemented as an enum to facilitate addition of other options in the
future.
Cleaned up some old lint in auto_parse.c.
Testing: created error conditions, checked behavior of overwriting
slice, multiple slices, tested proper manifest validation, tested
defaulting.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
