On 05/14/10 01:16 PM, Sue Sohn wrote:
On 05/12/10 10:53, Dave Miner wrote:
I need reviewers for
15784 slim_source gate should build IPS packages by default
I've prepared two webrev's.
First one is the full webrev against current slim_source and is the
primary review:
http://cr.opensolaris.org/~dminer/slim_15784/
Since the basic infrastructure for doing this is a direct port from the
fine work done by Liane, Mark, Rich and others for ON, I've also
prepared a secondary webrev which shows what I've changed in the files
that are ported from ON, as those changes are really the interesting
part of reviewing those files.
http://cr.opensolaris.org/~dminer/slim_15784_on/
Thanks for your help!
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Dave,
Did you want the following "osnet"s to be "install"s?
usr/src/pkg/transforms/synthetic:
34<transform depend fmri=pkg:/consolidation/osnet/install-incorporat...@.+
-> drop>
usr/src/pkg/transforms/publish:
50<transform set name=osnet.publish value=false -> abort>
51<transform set name=osnet.publish -> drop>
Accepted and fixed. We don't presently have any cases where we're using
the in-manifest transforms, so the error in publish didn't show up.
For the usr/src/pkg/manifests/*.mf files:
o usually on line 28: Is 2008 intentional?
Yes. It's referring to a specific classification taxonomy that was
written up and reviewed back then.
o most have the line: license cr_Sun license=cr_Sun
Should this be changed to cr_Oracle? And should the
usr/src/pkg/license_files/cr_Sun file be renamed?
For now, I'll leave it, as it's identical to ON.
o system-install-text-install.mf and system_install.mf are missing the
license line, should it be added?
Accepted and fixed.
And for:
usr/src/cmd/text-install/helpfiles/Makefile
usr/src/pkgdefs/SUNWtext-install/prototype_com
since text install files were externally visible in 2009, we've been using 2009,
2010 for the Copyright.
Accepted and fixed.
Thanks for the review.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
