On 09/15/10 11:50 AM, Dave Miner wrote:
On 09/15/10 01:42 PM, Jack Schwartz wrote:
Hi Dave.
On 09/15/10 08:45 AM, Dave Miner wrote:
Jack, Karen, Clay,
Thanks for review, a revised webrev is posted at same URL, below.
Regarding two of Clay's comments:
* Just to confirm, I believe what you're doing is equivalent to
the following too?
beadm list -Hd|grep ';R;'|cut -d ';' -f 2
Not quite, in that the nawk expression finds R anywhere in field 3, so
that additional state flags, such as in an entry like the below, don't
throw it off.
b-147;rpool/ROOT/b-147;NR;/;103153307136;static;1283816283
There is an implicit assumption in this method that there aren't
multiple pools with potentially active boot environments present in
the AI environment, which is true today but possibly not in the
future. It would be better to move this functionality into the AI
application so that it can directly handle the reboot to its known BE,
but we'll defer that to the post-conversion application, where I hope
we'll just fold the functionality in this script into the app.
Thanks for making the code changes.
I noticed that implicit assumption too. I think it would be useful to
add a comment about that assumption in svc/auto-installer. Do you agree?
(After all, you felt you had to explain it here...)
No, I don't think it's all that useful. It doesn't happen with the
current implementation and we expect to replace this code before it
would.
Dave
OK, fair enough. I'm OK with the changes.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
