Hi everyone, esp Dave.

Webrevs have been updated:

Full webrev, same location:
http://cr.opensolaris.org/~schwartz/100525.1/webrev/

Delta webrev:
http://cr.opensolaris.org/~schwartz/100525.1/webrev.2.1.diff/

I created a new directory /usr/lib/liveimg to put the script.

I ended up doing the two nawk's as single commands.  Here's the first:

# Check if mnttab has a line with "ramdisk" in $1 and a single / in $2
mnt_pnt=$(/usr/bin/nawk \
    '$1 ~ /ramdisk/ {if ($2 ~ /^\/$/) print $2}' /etc/mnttab)


For the last one I made use of passing $VARPKG in as an argument to nawk and extracting it using nawk's ARGV mechanism. Works great!

# If second token in mnttab line is $VARPKG, dump third token (fs type)
varpkg_fstype=$(/usr/bin/nawk \
    '{if ($2 == ARGV[2]) print $3}' /etc/mnttab $VARPKG)

Thanks again to Alex Eremin and Roland Mainz for their inputs.

Please let me know ASAP if you have any further comments.

    Thanks,
    Jack


On 05/26/10 08:32, Dave Miner wrote:
On 05/25/10 09:01 PM, Jack Schwartz wrote:
Hi everyone.

Here is a webrev that removes the service introduced by Driver Update to
copy /var/pkg when a live image boots. This effort replaces that service
with an on-demand script which the DDU will call when it invokes pkg(5).

http://cr.opensolaris.org/~schwartz/100525.1/webrev/

Changes consist of the following:
1) Removal of the live-var-pkg-move service.
2) Addition of the live_img_pkg5_prep script, to be called by the DDU.
3) Removal of /var/pkg and padding from the boot_archive in manifests.

Changes to the DDU are not reflected here, but were discussed along with
these changes on caiman-discuss last week. DDU will simply check for
existance of the live_img_pkg5_prep script (which will exist only on
live images) and will call it if available. Webrev to follow from DDU
team shortly.

The live_img_pkg5_prep script has been extensively unit tested.
X86 AI image has successfully invoked DDU to install an IPS package
Will test other images tomorrow to be sure, but mechanism is same for all.

Please review by Thursday lunchtime to allow enough time to get into B141.


Should live_img_pkg5_prep really be a /bin/ksh93 executable and not /bin/sh? The builtin's seem ksh93-specific. Also, "/etc/mount" (line 75) isn't right, /sbin/mount, please. It's a nit, but I'd think you could do everything on 57-58 with a single nawk invocation.

The new utility should not go under /usr/sbin. It has no use to a general administrative user and we have no intention of providing a man page for it, so it shouldn't be in a directory that would ever appear in a user's PATH. Probably the best thing would be to put it under /usr/lib/install (new directory, I realize).

Dave


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to