Hi Roland.
On 05/27/10 10:16 AM, Roland Mainz wrote:
On Thu, May 27, 2010 at 7:11 PM, Jack Schwartz<[email protected]> wrote:
Thanks, Jan.
Issue below is fixed in the final code.
One minor nit: Please use [[ ]] and not [ ] to compare string values.
[[ ]] is invulnerable to whitespace attacks (but make sure that the
right side is still inside "..." or a literal or it is interpreted as
pattern).
OK. When I looked into this, the manpage said that [[ ]] are for
general tests, not just strings. When I updated the script I included
other tests inside [[ ]].
While updating, I realized that the second test on line 67 would always
be true if the first one was, so I deleted it. (/var/pkg won't be a
link if it shows up in /etc/mnttab.)
----
Bye,
Roland
P.S.: Please check your scripts with ksh93 -n scriptname for errors,
usuallu it finds the horrible mistakes quickly...
I did this, and the script is clean.
Webrevs in the usual spot:
Full webrev, same location:
http://cr.opensolaris.org/~schwartz/100525.1/webrev/
Delta webrev:
http://cr.opensolaris.org/~schwartz/100525.1/webrev.4.3.diff/
Thanks again for your help.
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
