Hi Zhongyuan (of the DDU team).

On 05/26/10 08:52 PM, sunpers wrote:
Hi Jack,


---- 时间: Wed, 26 May 2010 12:35:03 -0700 *Jack Schwartz <[email protected] <mailto:[email protected]>>* 写道 ----

    HI Dave.

    Thanks for your review.

    On 05/26/10 08:32 AM, Dave Miner wrote:
    > On 05/25/10 09:01 PM, Jack Schwartz wrote:
    >> Hi everyone.
    >>
    >> Here is a webrev that removes the service introduced by Driver
    Update to
    >> copy /var/pkg when a live image boots. This effort replaces
    that service
    >> with an on-demand script which the DDU will call when it
    invokes pkg(5).
    >>
    >> http://cr.opensolaris.org/~schwartz/100525.1/webrev/
    <http://cr.opensolaris.org/%7Eschwartz/100525.1/webrev/>
    >>
    >> Changes consist of the following:
    >> 1) Removal of the live-var-pkg-move service.
    >> 2) Addition of the live_img_pkg5_prep script, to be called by
    the DDU.
    >> 3) Removal of /var/pkg and padding from the boot_archive in
    manifests.
    >>
    >> Changes to the DDU are not reflected here, but were discussed
    along with
    >> these changes on caiman-discuss last week. DDU will simply
    check for
    >> existance of the live_img_pkg5_prep script (which will exist
    only on
    >> live images) and will call it if available. Webrev to follow
    from DDU
    >> team shortly.
    >>
    >> The live_img_pkg5_prep script has been extensively unit tested.
    >> X86 AI image has successfully invoked DDU to install an IPS
    package
    >> Will test other images tomorrow to be sure, but mechanism is
    same for
    >> all.
    >>
    >> Please review by Thursday lunchtime to allow enough time to get
    into
    >> B141.
    >>
    >
    > Should live_img_pkg5_prep really be a /bin/ksh93 executable and not
    > /bin/sh? The builtin's seem ksh93-specific.
    Changed the shebang line to properly reflect ksh93.

    Note: It worked because sh points to ksh93.
    > Also, "/etc/mount" (line 75) isn't right, /sbin/mount, please.
    Changed.
    > It's a nit, but I'd think you could do everything on 57-58 with a
    > single nawk invocation.
    I'm not a nawk expert, but I'll take you up on the challenge. I've
    got
    this so far:

    /usr/bin/nawk '$1 ~ /ramdisk/ {print $2}' </etc/mnttab

    but I'm not sure how to do the regular expression for $2 being
    ^/$. Doing

    /usr/bin/nawk '$1 ~ /ramdisk/, $2 ~ /^\/$/ {print $2}' </etc/mnttab

    doesn't work. It matches anything where $2 has a / anywhere. Any
    hints?

    What about this:

    /usr/bin/nawk -F" " '{ if($1 ~ "ramdisk" && $2 ~ "^/$") print $2
    }' < /etc/mnttab

Thanks for your reply. I ended up doing something similar per another earlier suggestion. Take a look at the (updated) webrev if you are curious.

Please note that this script is now located in /usr/lib/install, so please update the DDU accordingly.

    Thanks,
    Jack



    Bests,
    Zhongyuan


    >
    > The new utility should not go under /usr/sbin. It has no use to a
    > general administrative user
    I was thinking someone could want to use it. Still it wouldn't be
    documented though...
    > and we have no intention of providing a man page for it, so it
    > shouldn't be in a directory that would ever appear in a user's
    PATH.
    > Probably the best thing would be to put it under
    /usr/lib/install (new
    > directory, I realize).
    OK. I'll figure out the Makefiles and respin the webrev as soon as
    I can...
    >
    > Dave
    >

    _______________________________________________
    caiman-discuss mailing list
    [email protected]
    <mailto:[email protected]>
    http://mail.opensolaris.org/mailman/listinfo/caiman-discuss



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to