On 06/ 2/10 09:40 AM, [email protected] wrote:
On 06/ 2/10 11:34 AM, Sue Sohn wrote:
Could I please get a review of the changes for:
13904 Logical Partition display issues on partition edit screen
14903 Partition screen highlights both Solaris2 and Extended
Partition sizes
15194 textui navigation issue with xvm
Note: Tests are included for 13904 and 14903. There is no test for 15194
(changing an environment variable). Thanks to Keith for
figuring out
how to instantiate a DiskWindow in the unit test environment.
Webrev:
http://cr.opensolaris.org/~sohn/13904_14903_15194
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hey Sue,
I only have 1 question.
File:
----------------
/usr/src/cmd/text-install/osol_install/text_install/disk_window.py
Question:
----------------
413 if active_win is not None:
Couldn't that be:
413 if active_win:
"if active_win is not None" ensures that active_win is not a pointer to
the "None" object.
"if active_win:" tests that the object active_win evaluates to True in a
boolean context.
In this specific context, it's perhaps splitting hairs, but given the
output from get_active_object(), the "is not None" format is more accurate.
As a more generic example, assume that get_active_object() returned
integer values in most cases, but returned None if something hadn't been
initialized. In such a scenario, a check for "if active_win" would break
if the return value was zero, even though zero could be a valid return
value.
- Keith
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
