Sue,
Thanks. Looks good. You might add a comment to the color_theme.py code
explaining
the situation so that someone behind you doesn't break the test and then
wonder why
it broke. Either way I am good with the changes.
Thanks,
John
On 06/ 2/10 11:18 AM, Sue Sohn wrote:
On 06/02/10 09:29, John Fischer wrote:
Sue,
Lots of good work here. I really need to play around with the
unittest stuff.
A couple of comments/questions:
o it seems that either putenv/getenv combination should be used
or environ[] only
Thanks for mentioning this. Turns out I was able to completely replace
lines 51-57 with:
environ.setdefault("ESCDELAY", "200")
but not a combination of both within __init__.py
o doesn't the 'has_colors' line within color_theme.py evaluate to
the samething?
It evaluates to the same thing which is the intent. The change was to
enable the instantiation of a DiskWindow in the unittest environment
without having curses initialized. The first clause fails since we set
force_bw=True and the second clause is not evaluated.
What's the benefit to switching the order of the evaluation?
o seems odd to add an '_' to function names when the reset of the
name space does
not do that within disk_window.py. Is this a change in how
the namespace is going
to be managed?
The underscores are implying that those functions are non-public, no
other meaning.
Note: I did not review the test code thoroughly as I am still coming
up to speed.
Though I did look at it and nothing jumped out at me. A
few comments might
help with future evolution of the testcase especially
around the do_nothing()
calls answering why it is OK to do nothing.
I added some comments to setup/teardown.
Updated webrev is at:
http://cr.opensolaris.org/~sohn/13904_14903_15194b
Thanks for the review,
Sue
Thanks,
John
On 06/ 2/10 08:34 AM, Sue Sohn wrote:
Could I please get a review of the changes for:
13904 Logical Partition display issues on partition edit screen
14903 Partition screen highlights both Solaris2 and Extended
Partition sizes
15194 textui navigation issue with xvm
Note: Tests are included for 13904 and 14903. There is no test for
15194
(changing an environment variable). Thanks to Keith for
figuring out
how to instantiate a DiskWindow in the unit test environment.
Webrev:
http://cr.opensolaris.org/~sohn/13904_14903_15194
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
