On 06/02/10 10:00, Keith Mitchell wrote:
On 06/ 2/10 08:34 AM, Sue Sohn wrote:
Could I please get a review of the changes for:
13904 Logical Partition display issues on partition edit screen
14903 Partition screen highlights both Solaris2 and Extended Partition
sizes
15194 textui navigation issue with xvm
Note: Tests are included for 13904 and 14903. There is no test for 15194
(changing an environment variable). Thanks to Keith for figuring
out
how to instantiate a DiskWindow in the unit test environment.
Thanks for slogging through what is, in kind terms, UI code with lots of
room for improvement.
Nit: The import statement in test_disk_window on lines 42-43 could be:
from osol_install.text_install.disk_window import DiskWindow
(and yes, that one is my fault).
Fixed this.
The webrev and tests look good.
Thanks for the review,
Sue
- Keith
Webrev:
http://cr.opensolaris.org/~sohn/13904_14903_15194
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
